Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pipeline stages #1534

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Rename pipeline stages #1534

merged 2 commits into from
Aug 17, 2022

Conversation

SimonSapin
Copy link
Contributor

Fixes #1138

@SimonSapin SimonSapin self-assigned this Aug 17, 2022
@SimonSapin SimonSapin enabled auto-merge (rebase) August 17, 2022 17:05
garypen
garypen approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

o0Ignition0o
o0Ignition0o approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM gogogo before there s new conflicts :D

@SimonSapin
Copy link
Contributor Author

There’s a new conflict 🤦

@o0Ignition0o
Copy link
Contributor

There’s a new conflict 🤦

https://external-content.duckduckgo.com/iu/?u=https%3A%2F%2Fmedia1.tenor.com%2Fimages%2F3f15a0a8771c2df66d081c76f830d80c%2Ftenor.gif%3Fitemid%3D18379274&f=1&nofb=1

@SimonSapin
Copy link
Contributor Author

Who had the audacity of making another PR touching the same area of the same file

(It was me)

@SimonSapin SimonSapin merged commit 7710b99 into main Aug 17, 2022
@SimonSapin SimonSapin deleted the simon/planninger branch August 17, 2022 17:43
@SimonSapin SimonSapin mentioned this pull request Aug 19, 2022
Merged
SimonSapin added a commit that referenced this pull request Aug 22, 2022
@SimonSapin
Change a telemetry span name from "router" to "supergraph"
949826a 
Follow up to #1534
@SimonSapin SimonSapin mentioned this pull request Aug 22, 2022
Merged
SimonSapin added a commit that referenced this pull request Aug 22, 2022
@SimonSapin
Change a telemetry span name from "router" to "supergraph"
6593c7a 
Follow up to #1534
SimonSapin added a commit that referenced this pull request Aug 22, 2022
@SimonSapin
Change a telemetry span name from "router" to "supergraph"
221ad05 
Follow up to #1534
SimonSapin added a commit that referenced this pull request Aug 22, 2022
@SimonSapin
Change a telemetry span name from "router" to "supergraph" (#1563)
01e3e45 
Follow up to #1534
@Geal Geal mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

@garypen garypen garypen approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@Geal Geal Awaiting requested review from Geal

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API 1.0 - Service naming
3 participants
@SimonSapin @o0Ignition0o @garypen