Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a consistent way to use endpoint path #2410

Merged
merged 7 commits into from
Jan 25, 2023
Merged

fix: add a consistent way to use endpoint path #2410

merged 7 commits into from
Jan 25, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Jan 16, 2023

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj self-assigned this Jan 16, 2023
@bnjjj bnjjj marked this pull request as draft January 16, 2023 16:37
@github-actions

This comment has been minimized.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj marked this pull request as ready for review January 17, 2023 09:52
bnjjj added 2 commits January 17, 2023 10:52
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from StephenBarlow as a code owner January 17, 2023 09:54
@bnjjj bnjjj requested review from garypen, Geal and BrynCooke and removed request for StephenBarlow January 17, 2023 09:55
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from garypen January 19, 2023 09:12
@bnjjj bnjjj requested a review from Geal January 24, 2023 09:15
@bnjjj bnjjj dismissed garypen’s stale review January 25, 2023 09:19

fix applied

@bnjjj bnjjj merged commit c5375e6 into dev Jan 25, 2023
@bnjjj bnjjj deleted the bnjjj/fix_2406 branch January 25, 2023 09:19
@abernix abernix mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration option for additional endpoint paths
4 participants