Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always use variable deduplication #2445

Merged
merged 5 commits into from
Jan 24, 2023
Merged

always use variable deduplication #2445

merged 5 commits into from
Jan 24, 2023

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jan 20, 2023 •
edited
Loading

Variable deduplication is an easy optimization that can have a huge impact on large federated queries, that was not active by default so far.

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

always use variable deduplication
cfb8001 
this is an easy optimization that should be more largely used
@github-actions

This comment has been minimized.

Sign in to view
@Geal Geal marked this pull request as ready for review January 24, 2023 08:37
@Geal Geal requested a review from StephenBarlow as a code owner January 24, 2023 08:37
@Geal Geal requested review from a team, SimonSapin and abernix and removed request for a team January 24, 2023 08:37
@Geal Geal merged commit 09cff54 into dev Jan 24, 2023
@Geal Geal deleted the geal/default-variable-deduplication branch January 24, 2023 14:02
@abernix abernix mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abernix abernix abernix approved these changes

@bnjjj bnjjj bnjjj approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@SimonSapin SimonSapin Awaiting requested review from SimonSapin SimonSapin was automatically assigned from apollographql/router

Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable deduplication and query deduplication default behaviour
3 participants
@Geal @abernix @bnjjj