Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Simplify JWT Rhai examples and provide example main.rhai #3184

Merged
merged 4 commits into from
Jun 6, 2023
Merged

docs: Simplify JWT Rhai examples and provide example main.rhai #3184

merged 4 commits into from
Jun 6, 2023

Conversation

dbanty
Copy link
Contributor

@dbanty dbanty commented May 30, 2023

Updates the example JWT-related Rhai scripts based on friction-log findings. Specifically:

  1. Matches the style between examples (closures vs function pointers)
  2. Includes an example main.rhai file to make it more clear how to use both of these together
  3. Minimizes info in error responses when auth fails (best practice). Potentially we should add logging instead to help with debugging?

@dbanty dbanty requested a review from StephenBarlow as a code owner May 30, 2023 22:12
@router-perf
Copy link

router-perf bot commented May 30, 2023

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • xlarge-request - Stress test with 10 MB request payload
  • large-request - Stress test with a 1 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@StephenBarlow StephenBarlow requested a review from garypen June 1, 2023 21:16
@garypen garypen self-assigned this Jun 5, 2023
@garypen garypen enabled auto-merge (squash) June 5, 2023 09:35
@garypen
Copy link
Contributor

garypen commented Jun 5, 2023

closing and re-opening to try and trigger perf tests.

@garypen garypen closed this Jun 5, 2023
auto-merge was automatically disabled June 5, 2023 13:26

Pull request was closed

@garypen garypen reopened this Jun 5, 2023
@garypen garypen enabled auto-merge (squash) June 5, 2023 13:27
@dbanty
Copy link
Contributor Author

dbanty commented Jun 5, 2023

@garypen should I be making a changeset for this?

@garypen
Copy link
Contributor

garypen commented Jun 5, 2023

@garypen should I be making a changeset for this?

I would have let it slide, but since you've asked... :)

It would be nice to have a "documentation" changeset if you are happy to write one. I'll disable the auto-merge for now.

@garypen garypen disabled auto-merge June 5, 2023 16:08
@dbanty
Copy link
Contributor Author

dbanty commented Jun 5, 2023

Added, that xtask makes that really easy 🤩. Should be ready once you double check my notes @garypen.

@garypen garypen enabled auto-merge (squash) June 5, 2023 16:44
@garypen garypen disabled auto-merge June 6, 2023 08:19
@garypen garypen merged commit 7ae047d into apollographql:dev Jun 6, 2023
@dbanty dbanty deleted the simplify-jwt-rhai-examples branch June 6, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants