Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split out router events into its own module #3235

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Jun 7, 2023

Breaks down ./apollo-router/src/router.rs into its own module ./apollo-router/src/router/mod.rs with a sub-module ./apollo-router/src/router/events/mod.rs that contains all of the streams that we combine to start a router (entitlement, schema, reload, configuration, shutdown, more streams to be added). This change makes adding new events/modifying existing events a bit easier since it's not in one huge giant file to rule them all.

@EverlastingBugstopper EverlastingBugstopper self-assigned this Jun 7, 2023
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jun 7, 2023

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • no-graphos - Basic stress test, no GraphOS.
  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/refactor-router-events branch from a285ca7 to c9af239 Compare June 7, 2023 19:17
Copy link
Contributor

@bnjjj bnjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just error in the changelog but otherwise LGTM

.changesets/maint_avery_refactor_router_events.md Outdated Show resolved Hide resolved
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
@EverlastingBugstopper EverlastingBugstopper merged commit 69ec9ae into dev Jun 9, 2023
@EverlastingBugstopper EverlastingBugstopper deleted the avery/refactor-router-events branch June 9, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants