Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and document the ordering of plugins #3321

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin commented Jun 26, 2023

Fixes #3230
Fixes #3207

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

@github-actions
Copy link
Contributor

@SimonSapin, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 26, 2023

CI performance tests

  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • large-request - Stress test with a 1 MB request payload

@SimonSapin SimonSapin force-pushed the simon/plugin-ordering branch from 2ebe310 to 102b6c0 Compare June 29, 2023 11:33
@SimonSapin SimonSapin marked this pull request as ready for review June 29, 2023 11:33
@SimonSapin SimonSapin requested review from garypen, Geal and BrynCooke June 29, 2023 11:33
@SimonSapin SimonSapin merged commit 24397bd into dev Jun 30, 2023
@SimonSapin SimonSapin deleted the simon/plugin-ordering branch June 30, 2023 09:32
SimonSapin added a commit that referenced this pull request Jun 30, 2023
@BrynCooke BrynCooke mentioned this pull request Jul 7, 2023
Geal added a commit that referenced this pull request Jul 12, 2023
Fix #3102

We documented plugin ordering guarantees in #3321, but it is worth
calling out how ordering works between authentication and coprocessors,
as claims augmentation is a common use case
BrynCooke pushed a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce plugin ordering for all Apollo plugins Reaffirm and document plugin ordering
2 participants