-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: get rid of the tracing_fmt layer and use our own optimized one #4202
telemetry: get rid of the tracing_fmt layer and use our own optimized one #4202
Conversation
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
…graphql/router into bnjjj/improve_formatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, but let's follow up with tests before merging to dev.
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice performance improvement. Do we need any new tests?
@garypen Yes I will add tests now, but in a follow up PR to make sure PRs stay small and easy to review. But it will be easier to test our logs now we have our own layer I think |
…graphql/router into bnjjj/improve_formatter
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
CI performance tests
|
…graphql/router into bnjjj/improve_formatter
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
266db72
into
bnjjj/custom_attributes_telemetry
Some perf improvements to lazy parse the attribute for logs
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩