Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: get rid of the tracing_fmt layer and use our own optimized one #4202

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Nov 14, 2023

Some perf improvements to lazy parse the attribute for logs

NEW ===
Summary:
  Total:        78.7140 secs
  Slowest:      0.1418 secs
  Fastest:      0.0055 secs
  Average:      0.0196 secs
  Requests/sec: 2540.8439


OLD ===
Summary:
  Total:        86.7263 secs
  Slowest:      0.1005 secs
  Fastest:      0.0065 secs
  Average:      0.0216 secs
  Requests/sec: 2306.1057

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj self-assigned this Nov 14, 2023
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, but let's follow up with tests before merging to dev.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from Geal November 15, 2023 09:55
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice performance improvement. Do we need any new tests?

@bnjjj
Copy link
Contributor Author

bnjjj commented Nov 15, 2023

@garypen Yes I will add tests now, but in a follow up PR to make sure PRs stay small and easy to review. But it will be easier to test our logs now we have our own layer I think

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@BrynCooke BrynCooke closed this Nov 15, 2023
@BrynCooke BrynCooke reopened this Nov 15, 2023
@router-perf
Copy link

router-perf bot commented Nov 15, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj merged commit 266db72 into bnjjj/custom_attributes_telemetry Nov 15, 2023
5 of 10 checks passed
@bnjjj bnjjj deleted the bnjjj/improve_formatter branch November 15, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants