chore: use router bridge from federation-rs #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterating on avery's great work moving the rust parts of federation to a separate repository, we can now target the recently public federation-rs repository, which this commit achieves.
Geal
approved these changes
Feb 14, 2022
abernix
approved these changes
Feb 14, 2022
apollo-router-core/Cargo.toml
Outdated
| @@ -24,10 +24,10 @@ include_dir = "0.7.2" | |||
| lru = "0.7.2" | |||
| miette = { version = "3.3.0", features = ["fancy"] } | |||
| once_cell = "1.9.0" | |||
| router-bridge = { git = "https://github.com/apollographql/federation.git", rev = "950eb931e38746bb7cfed05382d6970a22e43cc4" } | |||
| router-bridge = { git = "https://github.com/apollographql/federation-rs.git", rev = "e72e470fa82f9edd2fc4089e6b30246d50ce5fff" } | |||
There was a problem hiding this comment.
Let's hold just a second and land this as soon as apollographql/federation-rs#35 lands (and have this point to the resulting commit)?
Then we can mark this PR as closing #458, too.
There was a problem hiding this comment.
Ok, that just happened! So the commit would be 6f1a7033d03ff7310644d033508256dcf759a602 (apollographql/federation-rs@6f1a703)
There was a problem hiding this comment.
merging if CI passes!
abernix
approved these changes
Feb 14, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating on avery's great work moving the rust parts of federation to a separate repository, we can now target the recently public federation-rs repository, which this commit achieves.