Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make OperationKind public #4489

Merged
merged 2 commits into from
Jan 18, 2024
Merged

make OperationKind public #4489

merged 2 commits into from
Jan 18, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jan 16, 2024

Fix #4410

OperationKind was already used in a public field but the type itself was still private.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jan 16, 2024

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode

@Geal Geal requested review from a team, garypen, BrynCooke and goto-bus-stop January 16, 2024 15:32
@Geal Geal merged commit 9f1d204 into dev Jan 18, 2024
12 checks passed
@Geal Geal deleted the geal/expose-OperationKind branch January 18, 2024 11:19
@abernix abernix mentioned this pull request Jan 19, 2024
Meschreiber pushed a commit that referenced this pull request Feb 1, 2024
Fix #4410

`OperationKind` was already used in a public field but the type itself
was still private.
smihica pushed a commit to smihica/router that referenced this pull request Feb 17, 2024
Fix apollographql#4410

`OperationKind` was already used in a public field but the type itself
was still private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose fetch.rs OperationKind Enum publicly
2 participants