Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use latest Windows 2019 image 2024.02.21 #4673

Merged
merged 4 commits into from
Apr 30, 2024
Merged

chore(ci): use latest Windows 2019 image 2024.02.21 #4673

merged 4 commits into from
Apr 30, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Feb 16, 2024 •
edited by abernix
Loading

Updates our notion of current to the latest version windows-server-2019-vs2019:2024.02.21 but pins it, so it doesn't change randomly.

@github-actions GitHub Actions
Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Feb 16, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@abernix
Copy link
Member

abernix commented Mar 21, 2024

we can always reopen.

@abernix abernix closed this Mar 21, 2024
@Geal Geal reopened this Apr 30, 2024
@Geal Geal changed the title test circleci's current windows image Use CircleCI's current Windows image Apr 30, 2024
@Geal Geal marked this pull request as ready for review April 30, 2024 10:35
@Geal Geal requested a review from a team April 30, 2024 10:35
Geal
Geal commented Apr 30, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
Geal
Geal commented Apr 30, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
abernix
abernix reviewed Apr 30, 2024
View reviewed changes
.circleci/config.yml Outdated
@@ -58,12 +58,12 @@ executors:
resource_class: macos.m1.medium.gen1
windows_build: &windows_build_executor
machine:
image: "windows-server-2019-vs2019:2022.08.1"
image: "windows-server-2019-vs2019:current"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geal According to the build output when you ran this initial commit (not the 2022 commit), the current value was windows-server-2019-vs2019:2024.02.21. Since it worked, let's use that image explicitly, rather than current? (And move on?)

I don't think we need to try and go for 2022, as this page from CircleCI doesn't indicate that the 2024.02.21 image is being deprecated. A 2022 upgrade seems like a 2.0 thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus, it looks like 2022 is already failing, so let's go for low hanging fruit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure,; the 2019 image is recent enough to be usable for a while

Geal
Geal commented Apr 30, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
Geal
Geal commented Apr 30, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@abernix abernix changed the title Use CircleCI's current Windows image chore(ci): use latest Windows 2019 image 2024.02.21 Apr 30, 2024
@Geal Geal enabled auto-merge (squash) April 30, 2024 12:37
@Geal Geal merged commit 370e973 into dev Apr 30, 2024
14 checks passed
@Geal Geal deleted the geal/test-circleci-current-windows-image branch April 30, 2024 13:04
Geal added a commit that referenced this pull request Apr 30, 2024
@Geal
chore(ci): use latest Windows 2019 image 2024.02.21 (#4673)
2f24772 
Updates our notion of `current` to the latest version
`windows-server-2019-vs2019:2024.02.21` but _pins_ it, so it doesn't
change randomly.
BrynCooke pushed a commit that referenced this pull request May 3, 2024
@Geal
chore(ci): use latest Windows 2019 image 2024.02.21 (#4673)
236d478 
Updates our notion of `current` to the latest version
`windows-server-2019-vs2019:2024.02.21` but _pins_ it, so it doesn't
change randomly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abernix abernix abernix approved these changes

Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geal @abernix