-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add conditions on custom attributes for spans + a new selector for graphql error #4987
Merged
+7,511
−1,738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Loading status checks…
…_4320
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Loading status checks…
…aphql error Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
CI performance tests
|
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@BrynCooke, please consider creating a changeset entry in |
…as a condition on response. This means stashing the value until you know it can be used.
Loading status checks…
…ary. Needs more tests.
7e4dd4f
to
58f9b17
Compare
9936428
to
4895316
Compare
Geal
reviewed
Apr 23, 2024
Geal
approved these changes
Apr 23, 2024
Also improve error output from serde a little.
Loading status checks…
…bute.
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
…to bnjjj/ROUTER_226
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
garypen
approved these changes
Apr 23, 2024
Is there a way to add client error code or error message to Router or Supergraph span attributes with this? Currently trace view only shows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the router does not set otel.status_description on spans. This is a special attribute that will also set the span status.
This means that even responses have errors or http status is not 200 spans are not flagged as an error.
To complicate matters further, other languages usually use exceptions and stack unwinding to set span status, both of which are not available to us in rust.
Example:
This will allow the user to set the description to something if there was an issue.
Suggest implementing using the existing condition logic and add two new selectors. This would check http status and if there are 1 or more graphql errors.
Fixes #4336
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩