Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Apollo signature generation fixes #5049

Closed

Conversation

bonnici
Copy link
Contributor

@bonnici bonnici commented Apr 30, 2024

Fixes a few issues with the router implementation of the signature generation. Mostly related to commas being inserted instead of spaces or vice-versa, but also includes a significant issue where fragments were not being included in the signature.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@router-perf
Copy link

router-perf bot commented Apr 30, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@garypen garypen self-assigned this Apr 30, 2024
@garypen garypen enabled auto-merge (squash) April 30, 2024 09:54
garypen added a commit that referenced this pull request Apr 30, 2024
To try and increase confidence that nothing is wrong with Nick's PR.

Replacement for #5049 which (for unknown reasons) isn't building
cleanly.

Fixes a few issues with the router implementation of the signature
generation. Mostly related to commas being inserted instead of spaces or
vice-versa, but also includes a significant issue where fragments were
not being included in the signature.

Co-authored-by: [bonnici](https://github.com/bonnici)
@garypen
Copy link
Contributor

garypen commented Apr 30, 2024

Closed because this was merged in #5054 .

@garypen garypen closed this Apr 30, 2024
auto-merge was automatically disabled April 30, 2024 14:50

Pull request was closed

Geal pushed a commit that referenced this pull request May 3, 2024
To try and increase confidence that nothing is wrong with Nick's PR.

Replacement for #5049 which (for unknown reasons) isn't building
cleanly.

Fixes a few issues with the router implementation of the signature
generation. Mostly related to commas being inserted instead of spaces or
vice-versa, but also includes a significant issue where fragments were
not being included in the signature.

Co-authored-by: [bonnici](https://github.com/bonnici)
BrynCooke pushed a commit that referenced this pull request May 3, 2024
To try and increase confidence that nothing is wrong with Nick's PR.

Replacement for #5049 which (for unknown reasons) isn't building
cleanly.

Fixes a few issues with the router implementation of the signature
generation. Mostly related to commas being inserted instead of spaces or
vice-versa, but also includes a significant issue where fragments were
not being included in the signature.

Co-authored-by: [bonnici](https://github.com/bonnici)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants