-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced signature generation #5153
Conversation
This reverts commit 3c71ca9.
CI performance tests
|
I've addressed the PR comments but I don't have access to push to this branch/PR. I made a new branch/PR but it's based on the latest dev code so there are some unrelated changes in the PR. If this branch is synced with dev I think the PR should look a lot cleaner. |
I just merged dev in both branches and solved conflicts, #5285 looks much smaller now |
I've merged #5285 into this branch now and addressed the remaining PR comments. |
3a74fc2
to
ab4f1ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple formatting suggestions. Changes look good, I think
Adds a new experimental configuration to support enhanced signature generation. The changes are:
Remove some hacks and quirks of the JS implementation related to properly sorting everything and using commas vs spaces
Includes aliases in the signature
Includes the full normalized form of input objects
Fixes ROUTER-262
Replaces PR #5062
To get this over the line the tests need a little refactoring to use insta and maybe Asset to allow easy addition of new tests.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩