Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Apollo metrics generation mode to new by default #5265

Closed
wants to merge 5 commits into from
Closed

Set Apollo metrics generation mode to new by default #5265

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4808d94
Change metrics generation mode to new by default
bonnici May 29, 2024
f54dc1c
Set Apollo metrics generation mode to new by default
bonnici May 29, 2024
b39ce8f
Add changeset
bonnici May 29, 2024
f52edb6
Merge branch 'dev' into njm/240529/sig-ref-default-mode
bonnici May 29, 2024
a721f11
Remove temp code
bonnici May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changesets/config_apollo_sig_ref_default_mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Set Apollo metrics generation mode to new by default ([PR #5265](https://github.com/apollographql/router/pull/5265))

Changes the default value of experimental_apollo_metrics_generation_mode to be new since all metrics are showing that identical signatures are references are being generated.

By [@bonnici](https://github.com/bonnici) in https://github.com/apollographql/router/pull/5265
2 changes: 1 addition & 1 deletion apollo-router/src/configuration/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,12 @@ pub(crate) enum ApiSchemaMode {
#[serde(rename_all = "lowercase")]
pub(crate) enum ApolloMetricsGenerationMode {
/// Use the new Rust-based implementation.
#[default]
New,
/// Use the old JavaScript-based implementation.
Legacy,
/// Use Rust-based and Javascript-based implementations side by side, logging warnings if the
/// implementations disagree.
#[default]
Both,
}

Expand Down
6 changes: 6 additions & 0 deletions apollo-router/src/query_planner/bridge_query_planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,12 @@ impl BridgeQueryPlanner {
usage_reporting.stats_report_key = sig;
}

tracing::info!(
"experimental_apollo_metrics_generation_mode: {:?}",
self.configuration
.experimental_apollo_metrics_generation_mode
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if your intent is to create a metric, that won't work like this. You should take a look here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, that was temporary code I should have deleted.


if matches!(
self.configuration
.experimental_apollo_metrics_generation_mode,
Expand Down
Loading