-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit lifecycle
metrics to Apollo
#5270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust API schema generation was enabled by default in #4931, but the metrics were not making it to us. This change affects two metrics: - `apollo.router.lifecycle.api_schema` - `apollo.router.lifecycle.license` Please check that it's okay for `.license` to be submitted as well.
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
BrynCooke
reviewed
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a suitable changelog explaining why we are now transmitting this info.
BrynCooke
approved these changes
May 29, 2024
Geal
approved these changes
May 29, 2024
Merged
lrlna
pushed a commit
that referenced
this pull request
Jun 3, 2024
Geal
pushed a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust API schema generation was enabled by default in #4931, but the metrics were not making it to us.
This change affects two metrics:
apollo.router.lifecycle.api_schema
apollo.router.lifecycle.license
Reviewers please check that it's okay for
.license
to be submitted as well.Fixes ROUTER-332