Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit lifecycle metrics to Apollo #5270

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented May 29, 2024

Rust API schema generation was enabled by default in #4931, but the metrics were not making it to us.

This change affects two metrics:

  • apollo.router.lifecycle.api_schema
  • apollo.router.lifecycle.license

Reviewers please check that it's okay for .license to be submitted as well.

Fixes ROUTER-332

Rust API schema generation was enabled by default in #4931, but the
metrics were not making it to us.

This change affects two metrics:
- `apollo.router.lifecycle.api_schema`
- `apollo.router.lifecycle.license`

Please check that it's okay for `.license` to be submitted as well.
@goto-bus-stop goto-bus-stop requested a review from BrynCooke May 29, 2024 08:50
@goto-bus-stop goto-bus-stop self-assigned this May 29, 2024

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented May 29, 2024

CI performance tests

  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • const - Basic stress test that runs with a constant number of users
  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled

Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a suitable changelog explaining why we are now transmitting this info.

@goto-bus-stop goto-bus-stop requested a review from BrynCooke May 29, 2024 10:11
@Geal Geal enabled auto-merge (squash) May 29, 2024 10:29
@Geal Geal merged commit 1ca4e7d into dev May 29, 2024
14 checks passed
@Geal Geal deleted the renee/submit-api-schema-metrics branch May 29, 2024 10:54
@Geal Geal mentioned this pull request May 29, 2024
lrlna pushed a commit that referenced this pull request Jun 3, 2024
Geal pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants