Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify subscription config #5311

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

Meschreiber
Copy link
Contributor

Quick clarification on the path configuration because it caused customer confusion,
In the long run, this page should be combined with https://www.apollographql.com/docs/graphos/operations/subscriptions , refactored, and include a reference for all configurations.

@Meschreiber Meschreiber requested a review from a team as a code owner May 31, 2024 19:32
@router-perf
Copy link

router-perf bot commented May 31, 2024

CI performance tests

  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • const - Basic stress test that runs with a constant number of users
  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled

Copy link

@kendallshearman kendallshearman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for all you do 🎉

Co-authored-by: Edward Huang <edward.huang@apollographql.com>
@Geal Geal requested a review from bnjjj June 3, 2024 07:46
@abernix abernix force-pushed the docs/clarify-subscription-config branch from ea39355 to 0e759e1 Compare June 3, 2024 17:31
@abernix
Copy link
Member

abernix commented Jun 3, 2024

@Meschreiber I'm going to see if merging in main fixes the failing test_updated check, which looked legit to me — not because of your fault, but because this is merging directly to main it could leave main in a broken state.

@Meschreiber
Copy link
Contributor Author

Thank you @abernix !

@abernix abernix enabled auto-merge (squash) June 3, 2024 17:39
@abernix abernix merged commit 878dbc1 into main Jun 3, 2024
13 checks passed
@abernix abernix deleted the docs/clarify-subscription-config branch June 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants