Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GraphOS tests when apollo key not present #5362

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

BrynCooke
Copy link
Contributor

A number of tests require APOLLO_KEY and APOLLO_GRAPH_REF to be present to execute successfully.
These are now skipped if these are not present.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@BrynCooke BrynCooke requested review from a team as code owners June 6, 2024 11:05

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jun 6, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@BrynCooke BrynCooke force-pushed the bryn/disable_tests_apollo_key_missing branch from 7912b44 to e2d7d97 Compare June 6, 2024 11:06
@BrynCooke BrynCooke force-pushed the bryn/disable_tests_apollo_key_missing branch from e2d7d97 to 5076770 Compare June 6, 2024 11:07
@Geal
Copy link
Contributor

Geal commented Jun 6, 2024

NIT: the test changes could be simplified with if graph_os_enabled() { return; }

@BrynCooke BrynCooke enabled auto-merge (squash) June 6, 2024 12:15
@BrynCooke
Copy link
Contributor Author

NIT: the test changes could be simplified with if graph_os_enabled() { return; }

Done: cf8d6ff

@BrynCooke BrynCooke merged commit 08889ec into dev Jun 6, 2024
13 of 14 checks passed
@BrynCooke BrynCooke deleted the bryn/disable_tests_apollo_key_missing branch June 6, 2024 13:19
@lrlna lrlna mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants