Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep release: v1.48.1 #5390

Merged
merged 4 commits into from
Jun 10, 2024
Merged

prep release: v1.48.1 #5390

merged 4 commits into from
Jun 10, 2024

Conversation

abernix
Copy link
Member

@abernix abernix commented Jun 10, 2024

Note

When approved, this PR will merge into the 1.48.1 branch which will — upon being approved itself — merge into main.

Things to review in this PR:

  • Changelog correctness (There is a preview below, but it is not necessarily the most up to date. See the Files Changed for the true reality.)
  • Version bumps
  • That it targets the right release branch (1.48.1 in this case!).

🐛 Fixes

Improve error message produced when a subgraph response doesn't include an expected content-type header value (Issue #5359)

To improve a common debugability challenge when a subgraph response doesn't contain an expected content-type header value, the error message produced will include additional details about the error.

Some examples of the improved error message:

  • HTTP fetch failed from 'test': subgraph response contains invalid 'content-type' header value "application/json,application/json"; expected content-type: application/json or content-type: application/graphql-response+json
    
  • HTTP fetch failed from 'test': subgraph response does not contain 'content-type' header; expected content-type: application/json or content-type: application/graphql-response+json
    

By @IvanGoncharov in #5223

Update apollo-compiler for two small improvements (PR #5347)

Updated our underlying apollo-rs dependency on our apollo-compiler crate to bring in two nice improvements:

  • Fix validation performance bug

    Adds a cache in fragment spread validation, fixing a situation where validating a query with many fragment spreads against a schema with many interfaces could take multiple seconds to validate.

  • Remove ariadne byte/char mapping

    Generating JSON or CLI reports for apollo-compiler diagnostics used a translation layer between byte offsets and character offsets, which cost some computation and memory proportional to the size of the source text. The latest version of ariadne allows us to remove this translation.

By @goto-bus-stop in #5347

📃 Configuration

Rename the telemetry selector which obtains the GraphOS operation id (PR #5337)

Renames a misnamed trace_id selector introduced in v1.48.0 to the value which it actually represents which is an Apollo GraphOS operation ID, rather than a trace ID. Apologies for the confusion! Unfortunately, we aren't able to produce an Apollo GraphOS trace ID at this time.

If you want to access this operation ID selector, here is an example of how to apply it to your tracing spans:

telemetry:
  instrumentation:
    spans:
      router:
        "studio.operation.id":
            studio_operation_id: true

This can be useful for more easily locating the operation in GraphOS' Insights feature and finding applicable traces in Studio.

By @bnjjj in #5337

abernix added 3 commits June 10, 2024 15:17
This bump actually took place in v1.48.0 via
#5269, but we hadn't updated the
documentation in the release preparation.
@router-perf
Copy link

router-perf bot commented Jun 10, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
@abernix abernix requested a review from bnjjj June 10, 2024 12:56
@abernix abernix merged commit f73ead6 into 1.48.1 Jun 10, 2024
11 of 12 checks passed
@abernix abernix deleted the prep-1.48.1 branch June 10, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants