-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(telemetry): add docs about standard instruments for subgraph #5422
Conversation
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by comment. This is a well-prepared PR! I left one comment. It would be good for @BrynCooke and @Meschreiber to take a looksie beyond that.
Co-authored-by: Jesse Rosenberger <git@jro.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some preposition nits, otherwise LGTM!
docs/source/configuration/telemetry/instrumentation/instruments.mdx
Outdated
Show resolved
Hide resolved
docs/source/configuration/telemetry/instrumentation/instruments.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
…#5319 Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Added documentations about standard instruments available at the subgraph service:
http.client.request.body.size
- A histogram of request body sizes for requests handled by subgraphs.http.client.request.duration
- A histogram of request durations for requests handled by subgraphs.http.client.response.body.size
- A histogram of response body sizes for requests handled by subgraphs.These instruments are configurable in
router.yaml
:Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩