-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge_query_planner): change log level for mismatches #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `experimental_query_planner_mode:both`, emit mismatch metrics as `debug` rather than `warn` as there are still a fair few mismatches.
@lrlna, please consider creating a changeset entry in |
CI performance tests
|
bnjjj
approved these changes
Jun 14, 2024
BrynCooke
approved these changes
Jun 14, 2024
Geal
approved these changes
Jun 14, 2024
IvanGoncharov
approved these changes
Jun 14, 2024
o0Ignition0o
approved these changes
Jun 17, 2024
lrlna
added a commit
that referenced
this pull request
Jun 17, 2024
When using `experimental_query_planner_mode:both`, emit mismatch metrics as debug rather than warn as there are still a fair few mismatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
experimental_query_planner_mode:both
, emit mismatch metrics asdebug
rather thanwarn
as there are still a fair few mismatches.