Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge_query_planner): change log level for mismatches #5450

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

lrlna
Copy link
Member

@lrlna lrlna commented Jun 14, 2024

When using experimental_query_planner_mode:both, emit mismatch metrics as debug rather than warn as there are still a fair few mismatches.

When using `experimental_query_planner_mode:both`, emit mismatch metrics as `debug` rather than `warn` as there are still a fair few mismatches.
@lrlna lrlna self-assigned this Jun 14, 2024
@lrlna lrlna requested review from a team as code owners June 14, 2024 13:16
Copy link
Contributor

@lrlna, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@lrlna lrlna requested review from SimonSapin and bnjjj and removed request for a team June 14, 2024 13:17
@router-perf
Copy link

router-perf bot commented Jun 14, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • no-tracing - Basic stress test, no tracing
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@bnjjj bnjjj enabled auto-merge (squash) June 14, 2024 13:21
@lrlna lrlna disabled auto-merge June 14, 2024 13:43
@lrlna lrlna merged commit 0f388fc into dev Jun 17, 2024
14 checks passed
@lrlna lrlna deleted the lrlna/mismatch-debug branch June 17, 2024 06:54
lrlna added a commit that referenced this pull request Jun 17, 2024
When using `experimental_query_planner_mode:both`, emit mismatch metrics as debug rather than warn as there are still a fair few mismatches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants