Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updated plan_simple_root_field_query_for_multiple_subgraphs test #5455

Merged

Conversation

duckki
Copy link
Contributor

@duckki duckki commented Jun 14, 2024

  • The test doesn't need to be ignored anymore, since It's no longer crashing.
  • However, the expected snapshot was not correct.
  • I generated a query plan from JS federation and it matched the Rust output!

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@duckki duckki changed the base branch from duckki/test-failure-comment-update to dev June 14, 2024 17:34
@router-perf
Copy link

router-perf bot commented Jun 14, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • no-tracing - Basic stress test, no tracing
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@duckki duckki changed the title updated plan_simple_root_field_query_for_multiple_subgraphs test test: updated plan_simple_root_field_query_for_multiple_subgraphs test Jun 14, 2024
@duckki duckki requested a review from dariuszkuc June 14, 2024 21:01
- It's no longer crashing and but the expected snapshot was not correct.
- I generated a query plan from JS federation and it matched the Rust output!
@dariuszkuc dariuszkuc force-pushed the duckki/update-plan_simple_root_field_query_for_multiple_subgraphs branch from 6adc7af to 5fe0413 Compare June 15, 2024 00:42
Copy link
Contributor

@dariuszkuc, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@duckki duckki enabled auto-merge (squash) June 15, 2024 00:58
@duckki duckki merged commit 8f848ee into dev Jun 15, 2024
13 of 14 checks passed
@duckki duckki deleted the duckki/update-plan_simple_root_field_query_for_multiple_subgraphs branch June 15, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants