Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in selection set equality checking #5457

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

sachindshinde
Copy link
Contributor

@sachindshinde sachindshinde commented Jun 14, 2024

Paired on this with @dariuszkuc

This PR fixes a bug in selection set equality checking where it compares the schema and selection set's type when it shouldn't.

Note that we encountered this bug when discovering that condition exclusion wasn't working as expected. With this bugfix, computing how to jump to each subgraph should be much faster when there are many subgraphs.

Co-authored-by: Derek Kuc <dkuc@apollographql.com>
Copy link
Contributor

@sachindshinde, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 14, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • no-tracing - Basic stress test, no tracing
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@dariuszkuc dariuszkuc merged commit 6be2b07 into dev Jun 14, 2024
14 of 15 checks passed
@dariuszkuc dariuszkuc deleted the sachin/derek/fix-selection-set-equality-checking branch June 14, 2024 19:28
lrlna pushed a commit that referenced this pull request Jun 17, 2024
This PR fixes a bug in selection set equality checking where it compares the schema and selection set's type when it shouldn't.

Note that we encountered this bug when discovering that condition exclusion wasn't working as expected. With this bugfix, computing how to jump to each subgraph should be much faster when there are many subgraphs.

Co-authored-by: Derek Kuc <dkuc@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants