Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify offline license options #5495

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

Meschreiber
Copy link
Contributor

Clarify that the --license <license_path> option is only available when running the router binary, not for use with rover dev

@Meschreiber Meschreiber requested a review from a team as a code owner June 20, 2024 17:53
@router-perf
Copy link

router-perf bot commented Jun 20, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • no-tracing - Basic stress test, no tracing
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • step - Basic stress test that steps up the number of users over time
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • large-request - Stress test with a 1 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • const - Basic stress test that runs with a constant number of users

@Meschreiber Meschreiber requested a review from a team June 20, 2024 18:16
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Meschreiber!

@lrlna
Copy link
Member

lrlna commented Jun 21, 2024

@Meschreiber does this have to target main, not dev? i think that's why snapshots are failing

@Meschreiber
Copy link
Contributor Author

Meschreiber commented Jun 21, 2024

@lrlna , ah interesting. Was hoping to target main so this gets published right away w/o waiting for the next release cycle. I know we've done this in the past for certain doc updates. 🤔

@lrlna lrlna requested review from a team as code owners June 24, 2024 14:23
@lrlna
Copy link
Member

lrlna commented Jun 24, 2024

@Meschreiber I just pushed a fix with updated snapshots. I think all the doc PRs you have open should pass after this one is merged.

@lrlna lrlna enabled auto-merge (squash) June 24, 2024 14:25
@Meschreiber
Copy link
Contributor Author

Thank you @lrlna !

@lrlna lrlna merged commit 3208a14 into main Jun 24, 2024
12 of 13 checks passed
@lrlna lrlna deleted the docs/offline-license-rover-callout branch June 24, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants