Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use shared HTTPConnection component #5536

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Meschreiber
Copy link
Contributor

@Meschreiber Meschreiber commented Jun 25, 2024

Uses shared <HttpConnection /> component introduced in apollographql/docs#889

See in deploy preview: https://deploy-preview-5536--apollo-router-docs.netlify.app/configuration/traffic-shaping#http2

@Meschreiber Meschreiber requested a review from a team as a code owner June 25, 2024 20:44
Copy link
Contributor

@Meschreiber, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 25, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@BrynCooke
Copy link
Contributor

@Meschreiber should the shared component not go here: https://github.com/apollographql/router/tree/dev/docs/shared
That way it's still all in the same repo.

@Meschreiber
Copy link
Contributor Author

@BrynCooke , that is where I started with it, but then the shared content needed to inject a variable (to show either subgraph or coprocessor). I couldn't find a way to do that nicely in the router repo, though that was already possible in the docs repo.

@Meschreiber Meschreiber merged commit 9225e21 into dev Jun 27, 2024
15 checks passed
@Meschreiber Meschreiber deleted the docs/use-shared-httpconnection-component branch June 27, 2024 15:50
BrynCooke pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants