Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab… #5665

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

theJC
Copy link
Contributor

@theJC theJC commented Jul 16, 2024

…le values

RollingUpdate maxSurge and maxUnavailable are commonly used deployment configuration values. This change makes their values able to be set via the router helm chart.

Fixes #5664


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Add suggested change per PR comments

Co-authored-by: Nishchal Gautam <cyberhck@users.noreply.github.com>
@router-perf
Copy link

router-perf bot commented Jul 19, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs helm/chart/router/README.md updating.

@BrynCooke BrynCooke requested review from garypen and BrynCooke July 22, 2024 08:22
@BrynCooke BrynCooke dismissed their stale review July 22, 2024 09:24

Readme gets updated on release

Comment on lines 222 to 229
rollingUpdate:
{}
# Adjust rolling update strategy. Can take absolute values or % values.
# (https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment)
# Defaults if not set are:
# maxUnavailable: 25%
# maxSurge: 25%

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have line 224 moved to line 221 and specified as a helm-docs style comment

Copy link
Contributor Author

@theJC theJC Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted and used helm-doc style comment per your feedback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garypen - are you good with this PR now with the adjustment made?

Copy link
Contributor Author

@theJC theJC Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garypen or @BrynCooke -- Sorry for the harassment, but can we get this merged in. I have at least one more PR I'd like to submit, but I'd like this one settled first before I do so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theJC Sorry about the delay, I've been on vacation.

@garypen garypen self-assigned this Aug 16, 2024
@garypen garypen requested a review from a team as a code owner August 16, 2024 12:07
@garypen garypen enabled auto-merge August 16, 2024 12:07
@garypen garypen merged commit 159c7b4 into apollographql:dev Aug 16, 2024
12 of 13 checks passed
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart: Support providing RollingUpdate maxSurge and maxUnavailable values
4 participants