-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart: Support providing RollingUpdate maxSurge and maxUnavailab… #5665
Conversation
Add suggested change per PR comments Co-authored-by: Nishchal Gautam <cyberhck@users.noreply.github.com>
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but needs helm/chart/router/README.md
updating.
helm/chart/router/values.yaml
Outdated
rollingUpdate: | ||
{} | ||
# Adjust rolling update strategy. Can take absolute values or % values. | ||
# (https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment) | ||
# Defaults if not set are: | ||
# maxUnavailable: 25% | ||
# maxSurge: 25% | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have line 224 moved to line 221 and specified as a helm-docs style comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted and used helm-doc style comment per your feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garypen - are you good with this PR now with the adjustment made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garypen or @BrynCooke -- Sorry for the harassment, but can we get this merged in. I have at least one more PR I'd like to submit, but I'd like this one settled first before I do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theJC Sorry about the delay, I've been on vacation.
…le values
RollingUpdate maxSurge and maxUnavailable are commonly used deployment configuration values. This change makes their values able to be set via the router helm chart.
Fixes #5664
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩