Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to Apollo reporting over OTel #5741

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

lennyburdette
Copy link
Contributor

@lennyburdette lennyburdette commented Jul 29, 2024

BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
@router-perf
Copy link

router-perf bot commented Jul 29, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@lennyburdette lennyburdette marked this pull request as ready for review July 30, 2024 15:25
@lennyburdette lennyburdette requested review from a team as code owners July 30, 2024 15:25
@lennyburdette lennyburdette requested a review from timbotnik July 30, 2024 15:25
Copy link
Member

@dylan-apollo dylan-apollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, pretty sure I heard agreement on this change in a previous meeting

.changesets/breaking_lb_next_apollo_otel_default.md Outdated Show resolved Hide resolved
@@ -0,0 +1,7 @@
### feat: default to Apollo reporting over OTel ([PR #5741](https://github.com/apollographql/router/pull/5741))

BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the config snippet to turn this back off?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, i don't know the answer. it's possible that by the time 2.0 is GA, the option will be removed entirely, so i'm not going to worry about it right now

.changesets/breaking_lb_next_apollo_otel_default.md Outdated Show resolved Hide resolved
Co-authored-by: Dylan Anthony <dylan@apollographql.com>
@lennyburdette lennyburdette merged commit 2264e10 into next Jul 31, 2024
12 checks passed
@lennyburdette lennyburdette deleted the lb/next/apollo-otel-default branch July 31, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants