-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default to Apollo reporting over OTel #5741
Conversation
BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, pretty sure I heard agreement on this change in a previous meeting
@@ -0,0 +1,7 @@ | |||
### feat: default to Apollo reporting over OTel ([PR #5741](https://github.com/apollographql/router/pull/5741)) | |||
|
|||
BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include the config snippet to turn this back off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea, i don't know the answer. it's possible that by the time 2.0 is GA, the option will be removed entirely, so i'm not going to worry about it right now
Co-authored-by: Dylan Anthony <dylan@apollographql.com>
BREAKING CHANGE: This change will cause traces in Apollo Studio to appear differently
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩