-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for demand control directives when scoring operations #5777
Conversation
… directive extraction
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
Performance for demand control tests seems to be a bit under 6k rps. The current hotspot looks to be the repeated calls to get mapping for renamed directives, which we can deduplicate to a single call. |
4712bd1
to
4229a4c
Compare
…ds are not counted during scoring and that list inputs are properly scored
…init, and switch to ahash for HashSet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, it needs changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but @shorgi maybe tweak the changeset.
When scoring operations in the demand control plugin, utilize instances of
@cost
and@listSize
from the supergraph schema to make better cost estimates.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.