Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for demand control directives when scoring operations #5777

Merged
merged 33 commits into from
Aug 20, 2024

Conversation

tninesling
Copy link
Contributor

@tninesling tninesling commented Aug 5, 2024

When scoring operations in the demand control plugin, utilize instances of @cost and @listSize from the supergraph schema to make better cost estimates.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

@tninesling tninesling requested review from a team as code owners August 5, 2024 21:11

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 5, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@tninesling tninesling marked this pull request as draft August 5, 2024 21:17
@tninesling
Copy link
Contributor Author

Performance for demand control tests seems to be a bit under 6k rps. The current hotspot looks to be the repeated calls to get mapping for renamed directives, which we can deduplicate to a single call.

@tninesling tninesling marked this pull request as ready for review August 7, 2024 19:03
@tninesling tninesling marked this pull request as draft August 8, 2024 21:21
@tninesling tninesling marked this pull request as ready for review August 9, 2024 17:31
@tninesling tninesling force-pushed the tninesling/cost-directives branch 2 times, most recently from 4712bd1 to 4229a4c Compare August 10, 2024 00:53
@tninesling tninesling marked this pull request as draft August 10, 2024 00:54
@tninesling tninesling marked this pull request as ready for review August 13, 2024 03:34
@tninesling tninesling requested a review from BrynCooke August 13, 2024 03:34
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, it needs changelog.

@tninesling tninesling requested a review from a team as a code owner August 19, 2024 15:02
@tninesling tninesling requested a review from BrynCooke August 19, 2024 15:15
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but @shorgi maybe tweak the changeset.

@tninesling tninesling merged commit 7e29b5d into dev Aug 20, 2024
12 of 13 checks passed
@tninesling tninesling deleted the tninesling/cost-directives branch August 20, 2024 15:32
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants