Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Datadog sampling priority not set (#5703)" #5780

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Aug 6, 2024

This reverts commit 901eb56.

Multiple users have reported that the above commit causes the metrics on the APM view in Datadog to disappear.

Efforts to reproduce the issue internally have failed.
I have checked the payload being sent to the datadog agent with and without this change - and they look identical.

That being said, until we can figure out a concrete cause and reproduction we should revert this.

Two commits that follow the revert move the test that was lost over and adds a changelog.

Manual testing:

  • Send many requests to the router and verified the number of traces in the APM view matched.
  • Verified that traces were visible via trace explorer.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

  • No new features, so no docs.
  • Integration testing instead of unit testing because datadog interaction is required.

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 6, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@BrynCooke BrynCooke marked this pull request as ready for review August 7, 2024 10:18
@BrynCooke BrynCooke requested review from a team as code owners August 7, 2024 10:18
@BrynCooke BrynCooke requested a review from a team as a code owner August 7, 2024 10:30
@BrynCooke BrynCooke merged commit 2153fba into dev Aug 7, 2024
14 checks passed
@BrynCooke BrynCooke deleted the bryn/revert-5703 branch August 7, 2024 18:15
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants