-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format
for trace ID propagation.
#5803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
BrynCooke
force-pushed
the
propagation-format
branch
from
August 12, 2024 17:53
a5a51c4
to
14ccf47
Compare
shorgi
reviewed
Aug 12, 2024
docs/source/configuration/telemetry/exporters/tracing/overview.mdx
Outdated
Show resolved
Hide resolved
docs/source/configuration/telemetry/exporters/tracing/overview.mdx
Outdated
Show resolved
Hide resolved
docs/source/configuration/telemetry/exporters/tracing/overview.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
….mdx Co-authored-by: Edward Huang <edward.huang@apollographql.com>
….mdx Co-authored-by: Edward Huang <edward.huang@apollographql.com>
BrynCooke
commented
Aug 13, 2024
docs/source/configuration/telemetry/exporters/tracing/overview.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
BrynCooke
commented
Aug 13, 2024
docs/source/configuration/telemetry/exporters/tracing/overview.mdx
Outdated
Show resolved
Hide resolved
garypen
approved these changes
Aug 14, 2024
This adds a new required config property, so previous configurations are now invalid. Is that intentional? |
The test added in 7b8d801#diff-6068839267e9a05b915684b22f2a0fc86168216efc92da3113cac6f0d8de8890 fails for example. |
Making it optional and fixing the related test failure on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When propagating trace ID to subgraph via header is is now possible to specify the format.
Note that incoming requests must some form of UUID either with or without dashes.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩