Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format for trace ID propagation. #5803

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Add format for trace ID propagation. #5803

merged 12 commits into from
Aug 14, 2024

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Aug 12, 2024

When propagating trace ID to subgraph via header is is now possible to specify the format.

telemetry:
  exporters:
    tracing: 
      propagation: 
        request: 
          header_name: "my_header"
          format: uuid

Note that incoming requests must some form of UUID either with or without dashes.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 12, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@BrynCooke BrynCooke requested a review from shorgi August 12, 2024 17:44
BrynCooke and others added 3 commits August 13, 2024 10:51
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
….mdx

Co-authored-by: Edward Huang <edward.huang@apollographql.com>
….mdx

Co-authored-by: Edward Huang <edward.huang@apollographql.com>
BrynCooke and others added 3 commits August 13, 2024 10:53
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
@BrynCooke BrynCooke marked this pull request as ready for review August 13, 2024 09:56
@BrynCooke BrynCooke requested review from a team as code owners August 13, 2024 09:56
@BrynCooke BrynCooke enabled auto-merge (squash) August 14, 2024 14:27
@BrynCooke BrynCooke merged commit 48a0623 into dev Aug 14, 2024
13 of 14 checks passed
@BrynCooke BrynCooke deleted the propagation-format branch August 14, 2024 14:33
@goto-bus-stop
Copy link
Member

This adds a new required config property, so previous configurations are now invalid. Is that intentional?

@goto-bus-stop
Copy link
Member

The test added in 7b8d801#diff-6068839267e9a05b915684b22f2a0fc86168216efc92da3113cac6f0d8de8890 fails for example.

@goto-bus-stop
Copy link
Member

Making it optional and fixing the related test failure on dev: #5824

@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants