Use consistent query
name in uplink metrics
#5816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a legitimate issue but it looks weird.
The
apollo_router_uplink_fetch_duration_seconds
metric has aquery
attribute which normally contains a simplified name, such aslicense
forapollo_router::uplink::LicenseQuery
orpersistentquerymanifest
forapollo_router::uplink::PersistentQueryManifestQuery
.But if the uplink fetch fails, the query attribute instead contains the whole type name,
apollo_router::uplink::licensequery
instead oflicense
.I suspect these were meant to be the same?