Report connectors errors as fetch errors

[pubmodmatt]

With connectors, the subgraph service and connector service are called from a fetch service. This created some differences in how errors from the subgraph service were being reported through the fetch service compared to when the subgraph service was called directly. These differences have been removed, so errors from the subgraph service, or errors when invoking the subgraph service, will be reported exactly as before - always as FetchError::SubrequestHttpError.

Additionally, HTTP errors from a connector REST API call are now also reported as FetchError::SubrequestHttpError, with the connector information in the service extension.

{
  "message": "HTTP fetch failed from 'posts.jsonPlaceholder http: GET /users/{$this.id!}/postsd': 404: Not Found",
  "extensions": {
    "code": "SUBREQUEST_HTTP_ERROR",
    "service": "posts.jsonPlaceholder http: GET /users/{$this.id!}/postsd",
    "reason": "404: Not Found",
    "http": {
      "status": 404
    }
  }
}

FetchError::SubrequestHttpError is consistently converted to a GraphQL error through to_graphql_error.

The connectors::Error::RequestLimitExceeded error from the connector service now also has a to_graphql_error function, and is reported out slightly differently since it is not an HTTP error (connectors will not make the HTTP request at all once the request limit is exceeded). The connector information is now included in the service extension in this case for consistency with the HTTP errors.

{
  "message": "Request limit exceeded",
  "extensions": {
    "service": "posts.jsonPlaceholder http: GET /users/{$this.id!}/posts",
    "code": "REQUEST_LIMIT_EXCEEDED"
  }
}

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Tests added and passing³
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[router-perf]

CI performance tests

• const - Basic stress test that runs with a constant number of users
• demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• enhanced-signature - Enhanced signature enabled
• events - Stress test for events with a lot of users and deduplication ENABLED
• events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• extended-reference-mode - Extended reference mode enabled
• large-request - Stress test with a 1 MB request payload
• no-tracing - Basic stress test, no tracing
• reload - Reload test over a long period of time at a constant rate of users
• step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• step-local-metrics - Field stats that are generated from the router rather than FTV1
• step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• step - Basic stress test that steps up the number of users over time
• xlarge-request - Stress test with 10 MB request payload
• xxlarge-request - Stress test with 100 MB request payload