Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit connectors debugging log only once #6062

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

lennyburdette
Copy link
Contributor

@lennyburdette lennyburdette commented Sep 26, 2024

with rover dev or hot reloading, plugins are initialized each supergraph update, leading to redundant logs


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

with rover dev or hot reloading, plugins are initialized each supergraph update, leading to redundant logs
@pubmodmatt
Copy link
Contributor

If the debug_extensions value changes from false to true, and the config is reloaded, showing the warning again would be desirable because it has just been turned on again. That doesn't matter for dev since it defaults to true always there, but if there is a case outside of dev where the config would be reloaded, it seems preferable to emit the warning every time.

@lennyburdette
Copy link
Contributor Author

I tested it this way:

  1. run router with --hot-reload and a config without connectors debugging: no warning message
  2. change the router to enable connectors debugging: the router reloads and emits the warning

if you were to switch it off and back on, you wouldn't see the warning again, but i think that's fine.

maybe in the future there could be a way to distinguish between supergraph updates and configuration updates, but until then i would prefer not to see this warning every time the supergraph updates.

Copy link
Contributor

@pubmodmatt pubmodmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we can't differentiate, it seems ok to optimize for the supergraph reloading case rather than the config reloading.

Co-authored-by: Matthew Hawkins <matthew.hawkins@apollographql.com>
@lennyburdette lennyburdette force-pushed the lb/next/one-time-connectors-warning branch from 4b02c9f to c0bbfc1 Compare September 26, 2024 18:58
@lennyburdette lennyburdette merged commit 7566197 into next Sep 27, 2024
11 checks passed
@lennyburdette lennyburdette deleted the lb/next/one-time-connectors-warning branch September 27, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants