-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emit connectors debugging log only once #6062
Conversation
with rover dev or hot reloading, plugins are initialized each supergraph update, leading to redundant logs
If the |
I tested it this way:
if you were to switch it off and back on, you wouldn't see the warning again, but i think that's fine. maybe in the future there could be a way to distinguish between supergraph updates and configuration updates, but until then i would prefer not to see this warning every time the supergraph updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we can't differentiate, it seems ok to optimize for the supergraph reloading case rather than the config reloading.
Co-authored-by: Matthew Hawkins <matthew.hawkins@apollographql.com>
4b02c9f
to
c0bbfc1
Compare
with rover dev or hot reloading, plugins are initialized each supergraph update, leading to redundant logs
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩