Mostly fix json schema generation for otel config. #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is such a big part of the config that it's worth having. It's possible that the schema is a little too lenient, and would allow invalid config for custom attributes or headers, but mostly it is OK.
This comment has been minimized.
This comment has been minimized.
added 2 commits
March 10, 2022 12:19
bnjjj
approved these changes
Mar 10, 2022
garypen
reviewed
Mar 10, 2022
Comment on lines
+117
to
+126
| #[derive(JsonSchema)] | ||
| #[allow(dead_code)] | ||
| enum ProtocolMirror { | ||
| /// GRPC protocol | ||
| Grpc, | ||
| // HttpJson, | ||
| /// HTTP protocol with binary protobuf | ||
| HttpBinary, | ||
| } | ||
|
|
There was a problem hiding this comment.
NIT: I presume this is a restricted copy of the telemetry Protocol struct which only contains the protocols we support.
In which case, maybe rename to ImplementedProtocol or RestrictedProtocol or ProtocolSubset...?
(It's definitely not a Mirror and that name doesn't give much of a hint about its purpose.)
There was a problem hiding this comment.
It's not even that, it is an exact copy of the otel struct. I'll add a comment though.
Add comment to say what a mirror enum is used for.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is such a big part of the config that it's worth having.
Previously we were short circuiting the schema mechanism as there various types are reused from Otel and these do not have schema generation.
It's possible that the schema is a little too lenient, and would allow invalid config for custom attributes or headers, but mostly it is OK.