Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Options for HTTP/1 Max Headers and Buffer Limits #6194

Merged
merged 34 commits into from
Nov 19, 2024

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Oct 24, 2024

You can use it like this:

limits:
  http1_request_max_headers: 200
  http1_request_max_buf_size: 200kb

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

You can use it like this:
```
supergraph:
  experimental_http1_max_headers: 200
```
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 24, 2024

✅ Docs Preview Ready

No new or changed pages found.

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Oct 24, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@IvanGoncharov IvanGoncharov force-pushed the i1g/max_headers branch 2 times, most recently from f84082f to 03760c7 Compare November 5, 2024 22:22
@abernix abernix changed the title Add supergraph.experimental_http1_max_headers option Add experimental http1 header options (size and count) Nov 8, 2024
Cargo.toml Outdated Show resolved Hide resolved
@abernix abernix marked this pull request as ready for review November 8, 2024 19:35
@abernix abernix requested review from a team as code owners November 8, 2024 19:35
@IvanGoncharov IvanGoncharov requested a review from a team as a code owner November 14, 2024 09:47
Copy link
Contributor

@Geal Geal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also looked at apollographql/hyper@c42aec7 and it looks ok too)

Cargo.lock Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
apollo-router/Cargo.toml Outdated Show resolved Hide resolved
apollo-router/src/plugins/limits/mod.rs Outdated Show resolved Hide resolved
docs/source/reference/router/configuration.mdx Outdated Show resolved Hide resolved
docs/source/reference/router/configuration.mdx Outdated Show resolved Hide resolved
docs/source/routing/security/request-limits.mdx Outdated Show resolved Hide resolved
docs/source/routing/security/request-limits.mdx Outdated Show resolved Hide resolved
@IvanGoncharov IvanGoncharov changed the title Add experimental http1 header options (size and count) Configuration Options for HTTP/1 Max Headers and Buffer Limits Nov 18, 2024
@IvanGoncharov IvanGoncharov merged commit d2365a9 into dev Nov 19, 2024
14 checks passed
@IvanGoncharov IvanGoncharov deleted the i1g/max_headers branch November 19, 2024 09:30
@abernix abernix mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants