-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Options for HTTP/1 Max Headers and Buffer Limits #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can use it like this: ``` supergraph: experimental_http1_max_headers: 200 ```
✅ Docs Preview ReadyNo new or changed pages found. |
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
IvanGoncharov
force-pushed
the
i1g/max_headers
branch
2 times, most recently
from
November 5, 2024 22:22
f84082f
to
03760c7
Compare
abernix
changed the title
Add
Add experimental http1 header options (size and count)
Nov 8, 2024
supergraph.experimental_http1_max_headers
option
abernix
reviewed
Nov 8, 2024
abernix
force-pushed
the
i1g/max_headers
branch
from
November 8, 2024 19:41
70d7e9e
to
e39447b
Compare
Geal
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (also looked at apollographql/hyper@c42aec7 and it looks ok too)
SimonSapin
reviewed
Nov 14, 2024
SimonSapin
approved these changes
Nov 14, 2024
Co-authored-by: Simon Sapin <simon@apollographql.com>
abernix
reviewed
Nov 18, 2024
IvanGoncharov
changed the title
Add experimental http1 header options (size and count)
Configuration Options for HTTP/1 Max Headers and Buffer Limits
Nov 18, 2024
abernix
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use it like this:
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩