Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct authorization directive composition #6216

Merged
merged 9 commits into from
Nov 5, 2024

Conversation

Meschreiber
Copy link
Contributor

@Meschreiber Meschreiber commented Oct 31, 2024

Makes authorization directive composition docs clearer

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 31, 2024

✅ Docs Preview Ready

No new or changed pages found.

This comment has been minimized.

@Meschreiber Meschreiber changed the title [WIP] docs: break out authorization directive composition into more sections docs: correct authorization directive composition Nov 4, 2024

The response from a subgraph did not match the GraphQL schema.

</Property>

</Property>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This additional </Property> was causing builds to fail, so corrected it here.

@Meschreiber Meschreiber marked this pull request as ready for review November 4, 2024 23:07
@Meschreiber Meschreiber requested a review from a team as a code owner November 4, 2024 23:07
@Meschreiber Meschreiber requested review from Geal, shorgi and goto-bus-stop and removed request for a team November 4, 2024 23:08
@Meschreiber Meschreiber force-pushed the docs/ms/clarify-scope-composition branch from 44822ef to 1827f7a Compare November 4, 2024 23:12
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches my understanding!

docs/source/configuration/authorization.mdx Outdated Show resolved Hide resolved
Co-authored-by: Renée <renee.kooi@apollographql.com>
@apollographql apollographql deleted a comment from Meschreiber Nov 5, 2024
@Meschreiber Meschreiber merged commit a8ba726 into dev Nov 5, 2024
13 of 14 checks passed
@Meschreiber Meschreiber deleted the docs/ms/clarify-scope-composition branch November 5, 2024 15:57
LongLiveCHIEF pushed a commit to StateFarmIns/router that referenced this pull request Nov 21, 2024
Co-authored-by: Renée <renee.kooi@apollographql.com>
@abernix abernix mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants