-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate & expand connectors headers validations #6278
Merged
dylan-apollo
merged 8 commits into
next
from
dylan/validate-reserved-headers-after-merge
Nov 19, 2024
Merged
Consolidate & expand connectors headers validations #6278
dylan-apollo
merged 8 commits into
next
from
dylan/validate-reserved-headers-after-merge
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Router will now fail to load a schema which defines a reserved header instead of failing at runtime. Single headers within `@connect` are also now supported.
✅ Docs Preview ReadyNo new or changed pages found. |
CI performance tests
|
pubmodmatt
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just one change requested on a new header error type.
pubmodmatt
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, there were four separate validations for headers:
to
andfrom
are both set or just one of them, and disallows duplicate headers.@source
@connect
headers in a similar code path, but one that didn't allow single header objects yet.This PR unifies the base definition of what's considered a valid
headers
argument, catching disallowed header names at composition time and at router schema load (so there's no need to validate again at runtime).Improves the locations of a number of validations, pointing at the specific header that errored rather than the whole
headers
block.