-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: propagate evaluated plans limit and paths limit to the native query planner #6316
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
This comment was marked as resolved.
This comment was marked as resolved.
@goto-bus-stop are you continuing this work still? is it just missing an integration test you wanted to do?
Looks like we are not using the |
2831314
to
d25d5e1
Compare
the main thing this needs is a test indeed. |
…ery planner The experimental `max_evaluated_plans` and `paths_limit` options were only propagated to the legacy JS planner, not the native query planner. Now they work with both planners.
c02ea79
to
54ff4bd
Compare
The experimental
max_evaluated_plans
andpaths_limit
options were only propagated to the legacy JS planner, not the native query planner.Now they work with both planners.
Adds integration tests for the
apollo.router.query_planning.plan.evaluated_plans
metric, with and withoutmax_evaluated_plans
set, with the legacy and the native query planners.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩