Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in persisted query metric attribute #6332

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix typo in persisted query metric attribute #6332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecd42a4
Fix typo in persisted query metric attribute
goto-bus-stop Nov 26, 2024
c238044
changeset
goto-bus-stop Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changesets/fix_renee_quieres_queries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
### Fix typo in persisted query metric attribute ([PR #6332](https://github.com/apollographql/router/pull/6332))

The `apollo.router.operations.persisted_queries` metric reports an attribute when a persisted query was not found.
Previously, the attribute name was `persisted_quieries.not_found`, with one `i` too many. Now it's `persisted_queries.not_found`.

By [@goto-bus-stop](https://github.com/goto-bus-stop) in https://github.com/apollographql/router/pull/6332
2 changes: 1 addition & 1 deletion apollo-router/src/services/layers/persisted_queries/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ impl PersistedQueryLayer {
} else {
tracing::info!(
monotonic_counter.apollo.router.operations.persisted_queries = 1u64,
persisted_quieries.not_found = true
persisted_queries.not_found = true
);
// if APQ is not enabled, return an error indicating the query was not found
Err(supergraph_err_operation_not_found(
Expand Down