Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated metrics #6361

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Remove deprecated metrics #6361

merged 8 commits into from
Dec 5, 2024

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Nov 29, 2024

Metrics

  • apollo_router_http_request_retry_total has been removed and will be supported now by http.client.request.duration metrics
    with the http.request.resend_count attribute which is automatically set when default_requirement_level is set to recommended.

  • apollo_router_timeout has been removed. This metric conflated timed-out requests from client to the router, and requests from the router to subgraphs.
    Timed-out requests have HTTP status code 504. Use the http.response.status_code attribute on the http.server.request.duration metric to identify timed-out router requests,
    and the same attribute on the http.client.request.duration metric to identify timed-out subgraph requests.

  • apollo_router_http_requests_total has been removed and replaced by http.server.request.duration metric for requests from clients to router and http.client.request.duration for requests from router to subgraphs.

  • apollo_router_http_request_duration_seconds_bucket has been removed and replaced by http.server.request.duration metric for requests from clients to router and http.client.request.duration for requests from router to subgraphs.

  • apollo_router_session_count_total has been removed and replaced by http.server.active_requests.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 29, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/router@next": {
      "remote": {
        "owner": "apollographql",
        "repo": "router",
        "branch": "bnjjj/fix_864"
      }
    }
  }
}
Name Link

Commit

753a77b

Preview

https://www.apollographql.com/docs/deploy-preview/7b9cd376e73965f5b504

Build ID

7b9cd376e73965f5b504

File Changes

0 new, 1 changed, 0 removed
* graphos/reference/migration/from-router-v1.mdx

Pages

1


1 pages published. Build will be available for 30 days.

@router-perf
Copy link

router-perf bot commented Nov 29, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj marked this pull request as ready for review December 3, 2024 14:45
@bnjjj bnjjj requested review from a team as code owners December 3, 2024 14:45
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow so much code deleted! Awesome work

@bnjjj bnjjj merged commit 3ab3a59 into next Dec 5, 2024
12 checks passed
@bnjjj bnjjj deleted the bnjjj/fix_864 branch December 5, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants