-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated metrics #6361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
✅ Docs Preview ReadyConfiguration{
"repoOverrides": {
"apollographql/router@next": {
"remote": {
"owner": "apollographql",
"repo": "router",
"branch": "bnjjj/fix_864"
}
}
}
}
1 pages published. Build will be available for 30 days. |
CI performance tests
|
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
BrynCooke
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow so much code deleted! Awesome work
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics
apollo_router_http_request_retry_total
has been removed and will be supported now byhttp.client.request.duration
metricswith the
http.request.resend_count
attribute which is automatically set whendefault_requirement_level
is set torecommended
.apollo_router_timeout
has been removed. This metric conflated timed-out requests from client to the router, and requests from the router to subgraphs.Timed-out requests have HTTP status code 504. Use the
http.response.status_code
attribute on thehttp.server.request.duration
metric to identify timed-out router requests,and the same attribute on the
http.client.request.duration
metric to identify timed-out subgraph requests.apollo_router_http_requests_total
has been removed and replaced byhttp.server.request.duration
metric for requests from clients to router andhttp.client.request.duration
for requests from router to subgraphs.apollo_router_http_request_duration_seconds_bucket
has been removed and replaced byhttp.server.request.duration
metric for requests from clients to router andhttp.client.request.duration
for requests from router to subgraphs.apollo_router_session_count_total
has been removed and replaced byhttp.server.active_requests
.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩