Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.59.0 reconcile #6472

Merged
merged 10 commits into from
Dec 17, 2024
Merged

1.59.0 reconcile #6472

merged 10 commits into from
Dec 17, 2024

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Dec 17, 2024

1.59.0 reconcile as there were conflicts in docs


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

bnjjj and others added 10 commits December 11, 2024 14:27
)

The router's native, Rust-based, query planner is now generally available and enabled by default.

The native query planner achieves better performance for a variety of graphs. In our tests, we observe:

* 10x median improvement in query planning time (observed via `apollo.router.query_planning.plan.duration`)
* 2.9x improvement in router’s CPU utilization
* 2.2x improvement in router’s memory usage
> Note: you can expect generated plans and subgraph operations in the native query planner to have slight differences when compared to the legacy, JavaScript-based query planner. We've ascertained these differences to be semantically insignificant, based on comparing ~2.5 million known unique user operations in GraphOS as well as comparing ~630 million operations across actual router deployments in shadow mode for a four month duration.

The native query planner supports Federation v2 supergraphs. If you are using Federation v1 today, see our migration guide on how to update your composition build step and subgraph changes are typically not needed.

The legacy, JavaScript, query planner is deprecated in this release, but you can still switch back to it if you are still using Federation v1 supergraph:
```yaml
experimental_query_planner_mode: legacy
```
> Note: The subgraph operations generated by the query planner are not guaranteed consistent release over release. We strongly recommend against relying on the shape of planned subgraph operations, as new router features and optimizations will continuously affect it.

Co-authored-by: Chandrika Srinivasan <chandrikas@users.noreply.github.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Shane Myrick <mail@shanemyrick.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
As per docs suggestion, remove this changeset
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Dec 17, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/router@dev": {
      "remote": {
        "owner": "apollographql",
        "repo": "router",
        "branch": "1.59.0-reconcile"
      }
    }
  }
}
Name Link

Commit

0e74f19

Preview

https://www.apollographql.com/docs/deploy-preview/f5ad77a63747cf507e38

Build ID

f5ad77a63747cf507e38

File Changes

1 new, 9 changed, 0 removed
+ graphos/routing/observability/client-awareness.mdx
* graphos/reference/router/telemetry/instrumentation/standard-attributes.mdx
* graphos/reference/router/telemetry/instrumentation/standard-instruments.mdx
* graphos/reference/router/telemetry/instrumentation/selectors.mdx
* graphos/reference/router/telemetry/metrics-exporters/datadog.mdx
* graphos/reference/router/telemetry/trace-exporters/datadog.mdx
* graphos/reference/router/configuration.mdx
* graphos/routing/observability/client-id-enforcement.mdx
* graphos/routing/security/persisted-queries.mdx
* graphos/routing/about-router.mdx

Pages

9


9 pages published. Build will be available for 30 days.

@router-perf
Copy link

router-perf bot commented Dec 17, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct!

@BrynCooke BrynCooke merged commit 880eede into dev Dec 17, 2024
13 checks passed
@BrynCooke BrynCooke deleted the 1.59.0-reconcile branch December 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants