Add batch exporter metrics and logging enhancements #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
BrynCooke
force-pushed
the
bryn/named_runtime_channel
branch
from
008e6a0 to
88d8e62
Compare
BrynCooke
force-pushed
the
bryn/named_runtime_channel
branch
4 times, most recently
from
8420ec4 to
06faaab
Compare
…orters are falling behind. The message now contains the provider: `OpenTelemetry trace error occurred: cannot send message to batch processor '<provider>-tracing' as the channel is full` In addition, a new metric has been added to `apollo.router.telemetry.batch_processor.errors`. Which allows users to determine which batch processor needs modifying and an indicator of how much.
BrynCooke
force-pushed
the
bryn/named_runtime_channel
branch
from
ad95f26 to
2e90737
Compare
bnjjj
reviewed
Jan 20, 2025
docs/source/reference/router/telemetry/instrumentation/standard-instruments.mdx
Outdated
Show resolved
Hide resolved
bnjjj
approved these changes
Jan 20, 2025
|
@Mergifyio backport 1.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
Co-authored-by: bryn <bryn@apollographql.com> (cherry picked from commit 26d7743)
6 tasks
BrynCooke
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporters fall behind they emit an error message that is not useful. It neither outputs the name of the batch processor or the has metrics on how many spans were dropped.
The message now contains the provider:
OpenTelemetry trace error occurred: cannot send message to batch processor '<provider>-tracing' as the channel is fullIn addition, a new metric has been added:
apollo.router.telemetry.batch_processor.errors- The number of errors encountered by exporter batch processors.name: One ofapollo-tracing,datadog-tracing,otlp-tracing,zipkin-tracing.error= One ofchannel closed,channel full.Which allows users to determine which batch processor needs modifying and an indicator of how much.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩