Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring log and error message style in to line with rust guidelines #721

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

BrynCooke
Copy link
Contributor

Rust style is no capital letter at the start of a sentence and no trailing punctuation.

rust-lang/api-guidelines@201d903

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ Deploy Preview for apollo-router-docs ready!

🔨 Explore the source changes: 7123f76

🔍 Inspect the deploy log: https://app.netlify.com/sites/apollo-router-docs/deploys/6239f913899af50008f03b51

😎 Browse the preview: https://deploy-preview-721--apollo-router-docs.netlify.app

@github-actions

This comment has been minimized.

@BrynCooke BrynCooke force-pushed the bryn/error-message-caps branch from e220c8b to 8cdc17d Compare March 22, 2022 15:26
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure acronyms should be lowercase, otherwise lgtm

@BrynCooke BrynCooke force-pushed the bryn/error-message-caps branch from 6de052c to 7123f76 Compare March 22, 2022 16:24
@BrynCooke BrynCooke merged commit 560e6cb into main Mar 22, 2022
@BrynCooke BrynCooke deleted the bryn/error-message-caps branch March 22, 2022 16:39
@abernix abernix added this to the v0.1.0-preview.1 milestone Mar 22, 2022
@BrynCooke BrynCooke self-assigned this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants