fix: OTLP default service.name and service.namespace #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for apollo-router-docs canceled. 🔨 Explore the source changes: acbb05b 🔍 Inspect the deploy log: https://app.netlify.com/sites/apollo-router-docs/deploys/6239fe76138b400008e07f85 |
BrynCooke
reviewed
Mar 22, 2022
BrynCooke
approved these changes
Mar 22, 2022
bnjjj
approved these changes
Mar 22, 2022
fixes #719 service.name and service.namespace did default correctly in jaeger configuration, but not in OTLP. This PR fixes this.
o0Ignition0o
force-pushed
the
igni/otlp_default_service_name
branch
from
0796a93 to
acbb05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #719
service.name and service.namespace did default correctly in jaeger configuration, but not in OTLP.
This PR fixes this.