Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry enhancements #850

Merged
merged 22 commits into from
Apr 22, 2022
Merged

Telemetry enhancements #850

merged 22 commits into from
Apr 22, 2022

Commits on Apr 22, 2022

  1. Add docs public to git ignore.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    cc3a570 View commit details
    Browse the repository at this point in the history

  2. Move the apollo config, update changelog

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    00726e8 View commit details
    Browse the repository at this point in the history

  3. Split configuration for Apollo so that tracing can go in the tracing … 

    …module and metrics can go in the metrics module.
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    fcd4c69 View commit details
    Browse the repository at this point in the history

  4. Introduce instrument layer 

    Move router_request span to telemetry plugin. There's no way to disable this plugin so it's OK.
Add logic for dynamic client name and client version header.
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3e20545 View commit details
    Browse the repository at this point in the history

  5. Print errors if config could not be reloaded.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    bec20dc View commit details
    Browse the repository at this point in the history

  6. Update test config files

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    2dda2aa View commit details
    Browse the repository at this point in the history

  7. Integration test for jaeger

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    48675e0 View commit details
    Browse the repository at this point in the history

  8. Fix build for windows and osx. 

    OSX had an issue with max UDP packet size
Windows has all sorts of file related issues. On the plus side the special handling for windows in circle has been removed as the root cause of the hang on windows is now known to be: rust-lang/rust#45572
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    94ab1d3 View commit details
    Browse the repository at this point in the history

  9. Lint + take in feedback around operation name

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    8efc39b View commit details
    Browse the repository at this point in the history

  10. Add logic to kill node processes on test termination

    @BrynCooke
    BrynCooke authored and bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    0be78a5 View commit details
    Browse the repository at this point in the history

  11. Remove all piping from external commands, it's not safe unless we rea… 

    …d via another thread (which we don't)
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    055df22 View commit details
    Browse the repository at this point in the history

  12. Revert operation suggestion, operation should be extracted before the… 

    … subgraph service.
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    23ba2f7 View commit details
    Browse the repository at this point in the history

  13. Take in feedback

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    93ba22e View commit details
    Browse the repository at this point in the history

  14. Removed instructions for developing without docker compose. It is onl… 

    …y going to get more complicated aw we add more integration tests. Docker compose is the way to go.
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    28a795a View commit details
    Browse the repository at this point in the history

  15. Router span name moved to constant.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    8113eed View commit details
    Browse the repository at this point in the history

  16. Update NEXT_CHANGELOG.md 

    Co-authored-by: Gary Pennington <gary@apollographql.com>
    @BrynCooke @garypen
    2 people authored and bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    68c2c6b View commit details
    Browse the repository at this point in the history

  17. Rename QueryCache#parse_query back to get. 

    Moved instrumentation info span to actual query parsing. It makes no sense to have a span on a cache as the cache hit will mean no time elapsed.  Users can now see a span when query parsing happens or no span if parsing did not take place.
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    ddca621 View commit details
    Browse the repository at this point in the history

  18. Extended integration test to also do hot reloading. Had to do some wo… 

    …rk to make this test fast enough.
    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    ef6b533 View commit details
    Browse the repository at this point in the history

  19. Simplify flush on drop for trace provider.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    0f5dd0f View commit details
    Browse the repository at this point in the history

  20. Added some minimal documentation.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    bf40b73 View commit details
    Browse the repository at this point in the history

  21. Fix compile error after rebase.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    5017c68 View commit details
    Browse the repository at this point in the history

  22. Fix doc error.

    bryn committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    4b15150 View commit details
    Browse the repository at this point in the history