Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix broken link #2113

Closed
wants to merge 2 commits into from
Closed

Conversation

pnodet
Copy link

@pnodet pnodet commented Sep 9, 2024

No description provided.

@pnodet pnodet requested review from a team as code owners September 9, 2024 16:15
@apollo-cla
Copy link

@pnodet: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Meschreiber
Copy link
Contributor

Hey @pnodet it looks like one of the CI checks is failing because of credential issues--possibly due to this repo not passing secrets to forked repos. Would you mind moving this change over to a branch on this repo? Also happy to do it myself, but wasn't sure if you wanted the contribution on your profile.

@pnodet
Copy link
Author

pnodet commented Sep 9, 2024

Hey @Meschreiber I don't have permissions for it.

Feel free to make the change I don't care haha. But you should have a look into the CI, it's weird and might discourage future outside collaborators

@Meschreiber
Copy link
Contributor

Will do and will do!

@Meschreiber
Copy link
Contributor

Closing in favor of #2114

@Meschreiber Meschreiber closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants