Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests against the [supergraph-demo #2175

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fix integration tests against the [supergraph-demo #2175

merged 2 commits into from
Sep 25, 2024

Conversation

dotdat
Copy link
Contributor

@dotdat dotdat commented Sep 25, 2024 •
edited
Loading

Fixes tests against the supergraph demo repo. In the previous iteration, the federation version resolver defaulted to the FederationVersion::LatestFedTwo when it should have been FederationVersion::LatestFedOne

@dotdat dotdat requested a review from a team as a code owner September 25, 2024 20:26
@dotdat dotdat changed the title Fixes integration tests against the [supergraph-demo Fix integration tests against the [supergraph-demo Sep 25, 2024
@dotdat dotdat merged commit dfc0d25 into main Sep 25, 2024
22 checks passed
@dotdat dotdat deleted the dotdat/resolve-federation-bug branch September 25, 2024 21:15
dylan-apollo added a commit that referenced this pull request Sep 26, 2024
@dylan-apollo
Default fed version to 1 (#2175)
483ce42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronArinder aaronArinder aaronArinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotdat @aaronArinder