Add error for no profiles found (new user) #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeDawkins
requested review from
EverlastingBugstopper and
lrlna
as code owners
JakeDawkins
commented
Feb 23, 2021
| @@ -72,7 +72,7 @@ impl Display for RoverError { | |||
| suggestion_descriptor_message.push(' '); | |||
| } | |||
| let suggestion_descriptor = Cyan.bold().paint(&suggestion_descriptor_message); | |||
| write!(formatter, "{} {}", suggestion_descriptor, suggestion)?; | |||
| writeln!(formatter, "{} {}", suggestion_descriptor, suggestion)?; | |||
There was a problem hiding this comment.
This was mentioned by Jesse-
zsh prints a % after a command if it doesn't end with a newline
JakeDawkins
added
the
feature 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we could potentially build off this for a custom printer to avoid printing the
error:syntax. This is just to get something out there for the preview :)