This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
promisedParams
resolves to an exception then the error will be handled twice; once here:subscriptions-transport-ws/src/server.ts
Lines 418 to 425 in 34d503a
and once here:
subscriptions-transport-ws/src/server.ts
Lines 430 to 432 in 34d503a
this PR resolves that issue. It's a very minor fix, so shouldn't require any test changes.
TODO: