This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
feat(client): add minTimeout option #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge soon |
|
can I please get an update about when this will get merged? Am I going to have to resort to monkeypatching (if it's even possible) to fix the spurious #295 disconnect messages we're getting in production? |
|
When will this be merged? |
fahidenver
approved these changes
Jul 24, 2020
hwillson
force-pushed
the
fix/min-connect-timeout
branch
from
a327f76
to
e33f37a
Compare
hwillson
force-pushed
the
fix/min-connect-timeout
branch
from
fea9ed9
to
61ff7e0
Compare
hwillson
approved these changes
Aug 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually fix #295 completely
Does anyone care if I add tests for this? It's not really "significant new logic"
TODO: