Prevent three queries #2

mightymercado · 2021-05-14T09:23:15Z

Logic:

Prevent chewy from doing a count + fetch + fetch query. Instead, do a fetch only (and just use array length. Find and count have same performance
If you passed a list of Mongoid::Document, we should not do a mongo query to fetch them again. There are two important conditions.
- doc.__selected_fields has to be nil. It means that it wasn't queried with .only(*fields)
- default_scope / indexable_criteria has to be empty. There is no builtin way to check if a Mongoid::Document satisfies a Mongoid::Criteria other than querying mongo. So I will leave it to future optimization to manually define a corresponding proc on each of our indexable_criteria functions.

mightymercado · 2021-05-14T16:05:13Z

lib/chewy/type/adapter/mongoid.rb

@@ -30,6 +30,41 @@ def import_scope(scope, options)
          end.all?
        end

+        def import_objects(collection, options)


This is just a modified version of https://github.com/apolloio/chewy/blob/master/lib/chewy/type/adapter/orm.rb #import_objects

mightymercado added 2 commits May 14, 2021 17:21

Prevent double query

d817ed1

Skip those with indexable criteria for now

5d7d0e3

mightymercado changed the title ~~Prevent double query~~ Prevent three queries May 14, 2021

mightymercado requested a review from 3mammoth May 14, 2021 15:57

mightymercado commented May 14, 2021

View reviewed changes

3mammoth approved these changes May 14, 2021

View reviewed changes

allow passing of searchable proc

a708693

mightymercado merged commit 3f8ff3c into master May 14, 2021

Provide feedback